* Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx>: > On Wed, 28 May 2008 17:04:34 -0600 > Alex Chiang <achiang@xxxxxx> wrote: > > > > Any suggestions on how to move forward? My fixup patch did fix > > Badari's original oops in a syntactically sane manner; it was the > > semantics that were a bit trickier. > > What is "my fixup patch"? This is the patch I sent to Badari: http://lkml.org/lkml/2008/4/7/319 And after some confusion, it seemed to help: http://lkml.org/lkml/2008/4/16/265 My reading of the rpaphp stuff is that every slot should have a bus, so: if (slot->bus->self) shouldn't result in a NULL deref. That would be the syntactically sane part. At one point, Ben informed me that not every bus has a ->self, but I think it doesn't really matter in this case, no? Anyhow, that would be the semantic confusion on my end. > > Perhaps we could roll that last fixup patch into the series, aim > > for the next merge window, and see who complains? Obviously I'd > > work any issues that would pop up, and we could always revert it > > as a last resort. > > > > Or is that idea too sloppy for mainline? > > Well we _could_ slam it all in and say "good luck". t'would be nice to > get these things sorted out beforehand but this stuff has been floating > about for two months now. > > (Hey, this is Jesse's problem, not mine ;)) Looks like Jesse just replied in the affirmative. I reply to his mail. Thanks. /ac -- To unsubscribe from this list: send the line "unsubscribe linux-pci" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
