On 2024/12/20 22:28, Kevin Brodsky wrote:
On 20/12/2024 15:16, Qi Zheng wrote:
Did I miss something?
My patch series is not only for cleanup, but also for fixes of
UAF issue [1], so is it possible to rebase your patch series onto
mine? I can post v3 ASAP.
I see, yours should be merged first then. The issue is that yours would
depend on some of the patches in mine, not the other way round.
My suggestion would then be for you to take patch 5, 6 and 7 from my
series, as they match Alexander's suggestions (and patch 5 is I think a
useful simplification), and replace patch 2 in your series with those. I
would then rebase my series on top and adapt it accordingly. Does that
sound reasonable?
Sounds good. But maybe just patch 5 and 6. Because I actually did
the work of your patch 7 in my patch 2 and 4.
Yes that's fair! You'd have to do adapt my patch 7 to make it fit in
your series so I agree it makes more sense this way.
Thanks!
So, is it okay to do something like the following?
1. I separate the ctor()/dtor() part from my patch 2, and then replace
the rest with your patch 6.
2. take your patch 5 form your series
Sounds good to me!
IIUC Dave Hansen gave his Acked-by for the x86 part of patch 6 [1],
would make sense to add it when you post your v3.
OK, will add it!
If it's ok, I will post the v3 next Monday. ;)
Perfect. I'm going offline tonight, when I come back in the new year
I'll review your v3 series and post a new version of this one.
Thank you very much! And Happy New Year!
Cheers,
- Kevin
[1]
https://lore.kernel.org/linux-mm/a7398426-56d1-40b4-a1c9-40ae8c8a4b4b@xxxxxxxxx/
