On Thu, Dec 19, 2024, at 07:30, Thomas Weißschuh wrote:
> On Wed, Dec 18, 2024 at 05:35:31PM +0100, Arnd Bergmann wrote:
>>
>> > There is precedence in providing 64bit only vDSO functions, for example
>> > __vdso_clock_gettime64() in arm.
>> > I do have a small, so far untested, proof-of-concept patch for it.
>> > This would even be less code than the ifdefs.
>> >
>> > What do you think about it?
>>
>> Yes, simply exposing the normal time64 syscalls through vdso
>> should be fine. I think this currently works on everything except
>> rv32 and sparc32, probably because neither of them have actual
>> users that are able to test.
>
> Should it use the specific _vdso_clock_gettime64() naming or leave out
> the 64 suffix?
The VDSO function name should match the syscall name, with the '64'
suffix. Any syscall ending in _time64 uses the __kernel_time64_t
derived types, while the corresponding syscall names that don't end
in _time64 take a __kernel_old_time_t, which is defined as
__kernel_long_t and only 32 bits wide.
Arnd
