Re: [PATCH v2 3/5] mm: madvise: implement lightweight guard page mechanism

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 21.10.24 21:39, Lorenzo Stoakes wrote:
On Mon, Oct 21, 2024 at 12:25:08PM -0700, John Hubbard wrote:
On 10/21/24 10:23 AM, David Hildenbrand wrote:
[snip]
Just to raise it here: MADV_GUARD_INSTALL / MADV_GUARD_REMOVE or sth. like
that would have been even clearer, at least to me.

Yes, I think so.


:)

It still feels like poisoning to me because we're explicitly putting
something in the page tables to make a range have different fault behaviour
like a HW poisoning, and 'installing' suggests backing or something like
this, I think that's more confusing.

I connect "poison" to "SIGBUS" and "corrupt memory state", not to "there is nothing and there must not be anything". Thus my thinking. But again, not the end of the world, just wanted to raise it ...

"Poison" is used so far for fairly distinct things, and I'd very much like
to avoid extending its meaning to guard pages. It makes the other things
less unique, and it misses a naming and classification opportunity.

"Guard" and "guard page" are fairly unique names. That's valuable.


thanks,
--
John Hubbard


Guys you're breaking my heart... Will you not leave me with even a remnant
of a cultural reference?? [0]

I'm sure you will recover from that loss :)

--
Cheers,

David / dhildenb





[Index of Archives]     [Linux SoC]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux