Re: [PATCH] parisc/ftrace: Fix function graph tracing disablement

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 10/10/24 21:56, Josh Poimboeuf wrote:
On Thu, Oct 10, 2024 at 03:48:40PM -0400, Steven Rostedt wrote:
+++ b/arch/parisc/kernel/ftrace.c
@@ -87,7 +87,7 @@ int ftrace_enable_ftrace_graph_caller(void)

  int ftrace_disable_ftrace_graph_caller(void)
  {
-	static_key_enable(&ftrace_graph_enable.key);
+	static_key_disable(&ftrace_graph_enable.key);
  	return 0;
  }
  #endif

Awfully quite :-/

I wonder if anyone cares about parisc today?

Actually I do, and yes we have users.
Of course in reality that's "fun" users and not "productive" usage.

From programming perspective parisc is quite interesting since it
has an upwards-growing stack, limited ways of atomic ops,
and some awkward cache dependencies, so I regularly find
issues in generic Linux code which would not be found otherwise.

I still see some git activity in arch/parisc, so apparently so...

I only stumbled on this by accident (code inspection) while making
another unrelated change.

Thanks for your patch!
I'll apply it in my for-next git tree and push upstream at some point
(unless someone else takes it before me).

Helge





[Index of Archives]     [Linux SoC]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux