On 12/19/23 at 02:44pm, Conor Dooley wrote: > On Wed, Dec 13, 2023 at 01:57:45PM +0800, Baoquan He wrote: > > Then when specifying '-d' for kexec_file_load interface, loaded > > locations of kernel/initrd/cmdline etc can be printed out to help debug. > > > > Here replace pr_debug() with the newly added kexec_dprintk() in kexec_file > > loading related codes. > > > > And also replace pr_notice() with kexec_dprintk() in elf_kexec_load() > > because loaded location of purgatory and device tree are only printed > > out for debugging, it doesn't make sense to always print them out. > > > > And also remove kexec_image_info() because the content has been printed > > out in generic code. > > > > Signed-off-by: Baoquan He <bhe@xxxxxxxxxx> > > I'm sorry - I meant to look at this several days ago but I forgot. > Apart from the typo that crept back into $subject, this version explains > the rationale behind what you're changing a lot better, thanks. Thanks for careful checking. I forgot the typo fixing you have pointed out in v3 reviewing. Hi Andrew, Could you help fix the typo in subject? [PATCH v4 5/7] kexec_file, ricv: print out debugging message if required ~~~ s/ricv/riscv/