Re: [PATCH RFC 02/22] x86: intel_epb: Don't rely on link order

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Nov 28, 2023 at 02:40:59PM +0000, Jonathan Cameron wrote:
> On Tue, 07 Nov 2023 10:29:28 +0000
> Russell King <rmk+kernel@xxxxxxxxxxxxxxx> wrote:
> 
> > From: James Morse <james.morse@xxxxxxx>
> > 
> > intel_epb_init() is called as a subsys_initcall() to register cpuhp
> > callbacks. The callbacks make use of get_cpu_device() which will return
> > NULL unless register_cpu() has been called. register_cpu() is called
> > from topology_init(), which is also a subsys_initcall().
> > 
> > This is fragile. Moving the register_cpu() to a different
> > subsys_initcall()  leads to a NULL dereference during boot.
> > 
> > Make intel_epb_init() a late_initcall(), user-space can't provide a
> > policy before this point anyway.
> > 
> > Signed-off-by: James Morse <james.morse@xxxxxxx>
> > Signed-off-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx>
> 
> Seems reasonable. FWIW
> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@xxxxxxxxxx>

Thanks, however this has already been merged into the tip tree since
Rafael suggested sending it separately.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!




[Index of Archives]     [Linux SoC]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux