On 8/7/23 12:27?PM, Helge Deller wrote: > On 8/7/23 20:24, Jens Axboe wrote: >> On 8/7/23 12:04?PM, Helge Deller wrote: >>> The changes from commit 32832a407a71 ("io_uring: Fix io_uring mmap() by >>> using architecture-provided get_unmapped_area()") to the parisc >>> implementation of get_unmapped_area() broke glibc's locale-gen >>> executable when running on parisc. >>> >>> This patch reverts those architecture-specific changes, and instead >>> adjusts in io_uring_mmu_get_unmapped_area() the pgoff offset which is >>> then given to parisc's get_unmapped_area() function. This is much >>> cleaner than the previous approach, and we still will get a coherent >>> addresss. >>> >>> This patch has no effect on other architectures (SHM_COLOUR is only >>> defined on parisc), and the liburing testcase stil passes on parisc. >> >> What branch is this against? It doesn't apply to my 6.5 io_uring branch, >> which is odd as that's where the previous commits went through. > > applies for me on git head / Linux 6.5-rc5 Hmm, maybe something unrelated then. I'll take a look. The patch is garbled fwiw, but that's nothing new. If you download the raw one from lore you can see how. -- Jens Axboe