On Tue, May 23, 2023 at 07:16:55AM -0700, Dave Hansen wrote: > On 5/22/23 14:08, Luis Chamberlain wrote: > > --- a/arch/x86/kernel/umip.c > > +++ b/arch/x86/kernel/umip.c > > @@ -12,6 +12,7 @@ > > #include <asm/insn.h> > > #include <asm/insn-eval.h> > > #include <linux/ratelimit.h> > > +#include <linux/signal.h> > > Oh, so this is actually fixing a bug: umip.c uses > 'show_unhandled_signals' but it doesn't explicitly include > linux/signal.h where 'show_unhandled_signals' is declared. Fixes a non-critical bug perhaps, but I doubt it would be fixing a functional bug as otherwise folks would have reported a build bug, no? What or how it ends up including that file today to avoid build failures is beyond me. > It doesn't actually have anything to do with moving the > show_unhandled_signals sysctl, right? Well in my case it is making sure the sysctl variable used is declared as well. > If that's the case, it would be nice to have this in its own patch. If its not really fixing any build bugs or functional bugs I don't see the need. But if you really want it, I can do it. Let me know! Luis
