On 2/16/23 4:32 PM, Jens Axboe wrote: > On 2/16/23 4:26?PM, John David Anglin wrote: >> On 2023-02-16 6:12 p.m., Jens Axboe wrote: >>> On 2/16/23 4:00?PM, John David Anglin wrote: >>>> Running test buf-ring.t bad run 0/0 = -233 >>>> test_running(1) failed >>>> Test buf-ring.t failed with ret 1 >>> As mentioned previously, this one and the other -233 I suspect are due >>> to the same coloring issue as was fixed by Helge's patch for the ring >>> mmaps, as the provided buffer rings work kinda the same way. The >>> application allocates some aligned memory, and registers it and the >>> kernel then maps it. >>> >>> I wonder if these would work properly if the address was aligned to >>> 0x400000? Should be easy to verify, just modify the alignment for the >>> posix_memalign() calls in test/buf-ring.c. >> Doesn't help. Same error. Can you point to where the kernel maps it? > > Yep, it goes io_uring.c:io_uring_register() -> > kbuf.c:io_register_pbuf_ring() -> rsrc.c:io_pin_pages() which ultimately > calls pin_user_pages() to map the memory. Followup - a few of the provided buffer ring cases failed to properly initialize the ring, poll-mshot-race was one of them... I've pushed out fixes for this. Not sure if it fixes your particular issue, but worth giving it another run. -- Jens Axboe
