On Mon, Jul 04, 2022 at 11:57:28AM +0800, WANG Xuerui wrote: > > On 2022/7/4 04:50, Matthew Wilcox wrote: > > On Sun, Jul 03, 2022 at 05:12:01PM +0300, Mike Rapoport wrote: > > > +++ b/arch/loongarch/kernel/asm-offsets.c > > > @@ -190,7 +190,6 @@ void output_mm_defines(void) > > > #endif > > > DEFINE(_PTE_T_LOG2, PTE_T_LOG2); > > > BLANK(); > > > - DEFINE(_PGD_ORDER, PGD_ORDER); > > > BLANK(); > > > DEFINE(_PMD_SHIFT, PMD_SHIFT); > > > DEFINE(_PGDIR_SHIFT, PGDIR_SHIFT); > > Should probably also drop one of these BLANK() lines too? > > > Agreed; IMO the blank lines can and should be removed because the > surrounding lines are also mm definitions. They are mm definitions, but still they are separated by blanks to have nice grouping in the generated asm-offsets.h. I suspect that there are more unused definitions in asm-offsets.c, worth taking a look. -- Sincerely yours, Mike.
