On Thu, May 19, 2022 at 4:13 AM Jakub Kicinski <kuba@xxxxxxxxxx> wrote:
>
> Looks like almost all changes to this driver had been tree-wide
> refactoring since git era begun. There is one commit from Al
> 15 years ago which could potentially be fixing a real bug.
>
> The driver is using virt_to_bus() and is a real magnet for pointless
> cleanups. It seems unlikely to have real users. Let's try to shed
> this maintenance burden.
>
> Signed-off-by: Jakub Kicinski <kuba@xxxxxxxxxx>
> ---
> CC: corbet@xxxxxxx
> CC: tsbogend@xxxxxxxxxxxxxxxx
> CC: mpe@xxxxxxxxxxxxxx
> CC: benh@xxxxxxxxxxxxxxxxxxx
> CC: paulus@xxxxxxxxx
> CC: sburla@xxxxxxxxxxx
> CC: vburru@xxxxxxxxxxx
> CC: aayarekar@xxxxxxxxxxx
> CC: arnd@xxxxxxxx
Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---
> .../device_drivers/ethernet/dec/de4x5.rst | 189 -
> .../device_drivers/ethernet/index.rst | 1 -
> arch/mips/configs/mtx1_defconfig | 1 -
> arch/powerpc/configs/chrp32_defconfig | 1 -
> arch/powerpc/configs/ppc6xx_defconfig | 1 -
> drivers/net/ethernet/dec/tulip/Kconfig | 15 -
> drivers/net/ethernet/dec/tulip/Makefile | 1 -
> drivers/net/ethernet/dec/tulip/de4x5.c | 5591 -----------------
> drivers/net/ethernet/dec/tulip/de4x5.h | 1017 ---
I checked the defconfig files to make sure we are not removing the
last ethernet driver from
one of them. mtx1 has built-in networking and no PCI slot, so this is
definitely fine.
the ppc32 configs are for machines with PCI slots and also enable
multiple drivers but I saw
nothing specifically needing this card.
Arnd
