Am Freitag, 6. Mai 2022, 18:21:52 CEST schrieb Jakub Kicinski: > On Fri, 06 May 2022 12:11:56 +0200 Rolf Eike Beer wrote: > > Am Freitag, 6. Mai 2022, 11:42:50 CEST schrieb Yang Yingliang: > > > Fix the missing pci_disable_device() before return > > > from tulip_init_one() in the error handling case. > > > > I would suggest removing the pci_disable_device() from tulip_remove_one() > > instead and using pcim_enable_device(), i.e. devres, and let the driver > > core handle all these things. Of course more of the used functions could > > be converted them, e.g. using devm_alloc_etherdev() and so on. > > Let's not rewrite the error handling in this dinosaur of a driver > any more than absolutely necessary, please. Challenge accepted ;) [ 274.452394] tulip0: no phy info, aborting mtable build [ 274.499041] tulip0: MII transceiver #1 config 1000 status 782d advertising 01e1 [ 274.750691] net eth0: Digital DS21142/43 Tulip rev 65 at MMIO 0xf4008000, 00:30:6e:08:7d:21, IRQ 17 [ 283.104520] net eth0: Setting full-duplex based on MII#1 link partner capability of c1e1 Works fine, patch in a minute.
Attachment:
signature.asc
Description: This is a digitally signed message part.
