Re: [PATCH 01/12] parisc: Switch from GENERIC_CPU_DEVICES to GENERIC_ARCH_TOPOLOGY

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Am Freitag, 25. März 2022, 15:38:22 CET schrieb Helge Deller:
> Switch away from the own cpu topology code to common code which is used
> by ARM64 and RISCV. That allows us to enable hotplug later on too.

> diff --git a/arch/parisc/kernel/topology.c b/arch/parisc/kernel/topology.c
> index e88a6ce7c96d..72d9aeb54fbe 100644
> --- a/arch/parisc/kernel/topology.c
> +++ b/arch/parisc/kernel/topology.c
> @@ -71,6 +37,12 @@ void __init store_cpu_topology(unsigned int cpuid)
>  	if (cpuid_topo->core_id != -1)
>  		return;
> 
> +#ifdef CONFIG_HOTPLUG_CPU
> +	per_cpu(cpu_devices, cpuid).hotpluggable = 1;
> +#endif
> +	if (register_cpu(&per_cpu(cpu_devices, cpuid), cpuid))
> +		printk("Failed to register CPU device");
> +

This seems to be missing a level, and I think also printing the id of the 
failing CPU wouldn't hurt either.

Attachment: signature.asc
Description: This is a digitally signed message part.


[Index of Archives]     [Linux SoC]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux