On Wed, 13 Oct 2021 16:34:53 +0800 王贇 <yun.wang@xxxxxxxxxxxxxxxxx> wrote: > On 2021/10/13 下午4:25, Miroslav Benes wrote: > >>> Side note... the comment will eventually conflict with peterz's > >>> https://lore.kernel.org/all/20210929152429.125997206@xxxxxxxxxxxxx/. > >> > >> Steven, would you like to share your opinion on this patch? > >> > >> If klp_synchronize_transition() will be removed anyway, the comments > >> will be meaningless and we can just drop it :-P > > > > The comment will still be needed in some form. We will handle it depending > > on what gets merged first. peterz's patches are not ready yet. > > Ok, then I'll move it before trylock() inside klp_ftrace_handler() anyway. +1 -- Steve