On 10/11/21 17:05, Rolf Eike Beer wrote:
>> --- a/arch/parisc/include/uapi/asm/pdc.h
>> +++ b/arch/parisc/include/uapi/asm/pdc.h
>> @@ -689,6 +689,28 @@ struct pdc_hpmc_pim_20 { /* PDC_PIM */
>> unsigned long long fr[32];
>> };
>>
>> +struct pdc_toc_pim_11 {
>> + unsigned int gr[32];
>> + unsigned int cr[32];
>> + unsigned int sr[8];
>> + unsigned int iasq_back;
>> + unsigned int iaoq_back;
>> + unsigned int check_type;
>> + unsigned int hversion;
>> + unsigned int cpu_state;
>> +};
>> +
>> +struct pdc_toc_pim_20 {
>> + unsigned long long gr[32];
>> + unsigned long long cr[32];
>> + unsigned long long sr[8];
>> + unsigned long long iasq_back;
>> + unsigned long long iaoq_back;
>> + unsigned int check_type;
>> + unsigned int hversion;
>> + unsigned int cpu_state;
>> +};
>> +
>> #endif /* !defined(__ASSEMBLY__) */
>
> Since these are defined by the hardware and have a well defined size I suggest
> using u32 and u64 to cover this.
You're right.
But in the whole file we use "unsigned int" for 32bit, and "unsigned long long"
for 64bit, so this change is consistent with the other contents.
Helge
