On Sat, Aug 7, 2021 at 10:19 AM Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote: > > The caller of this function (parisc_driver_remove() in > arch/parisc/kernel/drivers.c) ignores the return value, so better don't > return any value at all to not wake wrong expectations in driver authors. > > The only function that could return a non-zero value before was > ipmi_parisc_remove() which returns the return value of > ipmi_si_remove_by_dev(). Make this function return void, too, as for all > other callers the value is ignored, too. > > Also fold in a small checkpatch fix for: > > WARNING: Unnecessary space before function pointer arguments > + void (*remove) (struct parisc_device *dev); > > Acked-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx> (for drivers/input) > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > --- > changes since v1 sent with Message-Id: > 20210806093938.1950990-1-u.kleine-koenig@xxxxxxxxxxxxxx: > > - Fix a compiler error noticed by the kernel test robot > - Add Ack for Dmitry > > arch/parisc/include/asm/parisc-device.h | 4 ++-- > drivers/char/ipmi/ipmi_si.h | 2 +- > drivers/char/ipmi/ipmi_si_intf.c | 6 +----- > drivers/char/ipmi/ipmi_si_parisc.c | 4 ++-- > drivers/char/ipmi/ipmi_si_platform.c | 4 +++- > drivers/input/keyboard/hilkbd.c | 4 +--- > drivers/input/serio/gscps2.c | 3 +-- > drivers/net/ethernet/i825xx/lasi_82596.c | 3 +-- > drivers/parport/parport_gsc.c | 3 +-- Acked-by: Sudip Mukherjee <sudipm.mukherjee@xxxxxxxxx> -- Regards Sudip
