Re: [PATCH] drivers: parisc: Update iosapic driver with proper printks

[Rolf Eike Beer <eike-kernel@xxxxxxxxx>]

Am Freitag, 9. Juli 2021, 15:38:44 CEST schrieb Carlos Bilbao:
> The code from the old I/O Sapic Driver is outdated when it comes to printks.
> Fix applying proper indentation and using dev_dbg() instead of printk on
> debugging blocks. Also add a KERN_<LEVEL> where it is missing.

Have you actually tried building this? I bet not:

> +#define DBG(x...) dev_dbg(x)

> +	DBG("io_sapic_info at %p\n", isi);
> +	DBG("\t\tisi_hpa:       %lx\n", isi->isi_hpa);
> +	DBG("\t\tisi_status:    %x\n", isi->isi_status);
> +	DBG("\t\tisi_version:   %x\n", isi->isi_version);
> +	DBG("\t\tisi_vector:    %p\n", isi->isi_vector);
>  }
>  #endif /* DEBUG_IOSAPIC */

You are not passing a struct device here, so this will not work.

Eike

Attachment: signature.asc
Description: This is a digitally signed message part.