On 10/22/20 9:11 PM, Meelis Roos wrote:
>
> 22.10.20 19:40 Helge Deller wrotw:
>> This patch adds wrapper functions for the relevant syscalls. The
>> wrappers masks out any old invalid O_NONBLOCK flags, reports in the
>> syslog if the old O_NONBLOCK value was used and then calls the target
>> syscall with the new O_NONBLOCK value.
>>
>> Fixes: 75ae04206a4d ("parisc: Define O_NONBLOCK to become 000200000")
>> Signed-off-by: Helge Deller <deller@xxxxxx>
>
> Works for me on RP2470 - boots up in full functionality and logs the recompilation
> warning about systemd-udevd and syslog-ng.
>
> Tested-by: Meelis Roos <mroos@xxxxxxxx>
Thank you Meelis & Jeroen for testing!
The big question is:
We have two options
a) revert my original commit 75ae04206a4d ("parisc: Define O_NONBLOCK to become 000200000"), or
b) apply and submit this new patch on top of it.
The benefit in b) is that we will get long term rid of the two-bit
O_NONBLOCK define and thus will get more compatible to other Linux
architectures. This comes with the downside of (at least for a few
years) added overhead for those non-performance critical syscalls.
The benefit with a) is that we then step back again and stay compatible
now. The downside is, that in the future we may run into other issues
and need to keep special-handling in some other syscalls forever.
I'm still for going with b), and I hope we got all corner cases ruled out.
Opinions?
Helge
