Hi Arnd, On Mon, Oct 12, 2020 at 5:31 PM Arnd Bergmann <arnd@xxxxxxxx> wrote: > On Mon, Oct 12, 2020 at 3:15 PM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote: > > Given this feature is SoC-specific, not platform-specific, perhaps > > it makes sense to move the selects to the M68{,EZ,VZ}328 symbols? > > > > Regardless: > > Reviewed-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > > Ok, folded in the change blow, using one less line. I couldn't figure Thanks, looks good. > out whether > it should just be part of the CONFIG_M68000 instead, which doesn't appear It must definitely not be selected by CONFIG_M68000, as the plain MC68000 is a CPU, not an SoC, and does not have the timer. > to have any machine support by itself. The dragonball CPU configuration > looks really odd, because you have to build exactly one of M68{,EZ,VZ}328 > into the kernel to get a successful compilation, while Kconfig allows > many other combinations. While CONFIG_M68000 could be used for a "pure" MC68000-based machine, I believe we don't support any yet. M68{,EZ,VZ}328 select M68000 as they are SoCs containing a 68000 CPU core. Other m68k SoCs have a CPU32 core, which is a simplified 68020 CPU core (hmm, what happened to 68360 support? Oh, removed in 2016, so nothing selects CPU32 anymore). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds