On Thu, May 07, 2020 at 01:53:07PM -0700, Andrew Morton wrote: > On Thu, 7 May 2020 08:00:03 -0700 ira.weiny@xxxxxxxxx wrote: > > > From: Ira Weiny <ira.weiny@xxxxxxxxx> > > > > Most architectures define kmap_prot to be PAGE_KERNEL. > > > > Let sparc and xtensa define there own and define PAGE_KERNEL as the > > default if not overridden. > > > > checkpatch considered useful ;) Yes sorry... V3.1 on it's way... Ira > > > From: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > Subject: kmap-consolidate-kmap_prot-definitions-checkpatch-fixes > > WARNING: macros should not use a trailing semicolon > #134: FILE: arch/sparc/include/asm/highmem.h:33: > +#define kmap_prot __pgprot(SRMMU_ET_PTE | SRMMU_PRIV | SRMMU_CACHE); > > total: 0 errors, 1 warnings, 100 lines checked > > NOTE: For some of the reported defects, checkpatch may be able to > mechanically convert to the typical style using --fix or --fix-inplace. > > ./patches/kmap-consolidate-kmap_prot-definitions.patch has style problems, please review. > > NOTE: If any of the errors are false positives, please report > them to the maintainer, see CHECKPATCH in MAINTAINERS. > > Please run checkpatch prior to sending patches > > Cc: Ira Weiny <ira.weiny@xxxxxxxxx> > Signed-off-by: Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> > --- > > arch/sparc/include/asm/highmem.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/arch/sparc/include/asm/highmem.h~kmap-consolidate-kmap_prot-definitions-checkpatch-fixes > +++ a/arch/sparc/include/asm/highmem.h > @@ -30,7 +30,7 @@ > /* declarations for highmem.c */ > extern unsigned long highstart_pfn, highend_pfn; > > -#define kmap_prot __pgprot(SRMMU_ET_PTE | SRMMU_PRIV | SRMMU_CACHE); > +#define kmap_prot __pgprot(SRMMU_ET_PTE | SRMMU_PRIV | SRMMU_CACHE) > extern pte_t *pkmap_page_table; > > void kmap_init(void) __init; > _ >
