Hi Michal, On Wed, Feb 12, 2020 at 10:16 AM Michal Simek <michal.simek@xxxxxxxxxx> wrote: > Generated files are also checked by sparse that's why add newline > to remove sparse (C=1) warning. > > The issue was found on Microblaze and reported like this: > ./arch/microblaze/include/generated/uapi/asm/unistd_32.h:438:45: > warning: no newline at end of file > > Signed-off-by: Michal Simek <michal.simek@xxxxxxxxxx> > Reviewed-by: Stefan Asserhall <stefan.asserhall@xxxxxxxxxx> Thanks for your patch! > arch/alpha/kernel/syscalls/syscallhdr.sh | 1 + > arch/ia64/kernel/syscalls/syscallhdr.sh | 1 + > arch/m68k/kernel/syscalls/syscallhdr.sh | 1 + Bummer, I had noticed that before https://lore.kernel.org/lkml/CAMuHMdVsBwL9vcqejfc47GN793wMXdQ=SwEsSUP1fbpMt-OoWw@xxxxxxxxxxxxxx/ and even claimed I fixed it while applying https://lore.kernel.org/lkml/CAMuHMdW6JiponxLiGNEXUX4xJk3hK4b8dTOCNvVBr7s2LyfhJw@xxxxxxxxxxxxxx/ but something must have gone wrong... > arch/microblaze/kernel/syscalls/syscallhdr.sh | 1 + > arch/parisc/kernel/syscalls/syscallhdr.sh | 1 + > arch/sh/kernel/syscalls/syscallhdr.sh | 1 + > arch/sparc/kernel/syscalls/syscallhdr.sh | 1 + > arch/xtensa/kernel/syscalls/syscallhdr.sh | 1 + > 8 files changed, 8 insertions(+) > > diff --git a/arch/alpha/kernel/syscalls/syscallhdr.sh b/arch/alpha/kernel/syscalls/syscallhdr.sh > index e5b99bd2e5e7..524c69fbcab7 100644 > --- a/arch/alpha/kernel/syscalls/syscallhdr.sh > +++ b/arch/alpha/kernel/syscalls/syscallhdr.sh > @@ -33,4 +33,5 @@ grep -E "^[0-9A-Fa-fXx]+[[:space:]]+${my_abis}" "$in" | sort -n | ( > printf "#endif\n" > printf "\n" > printf "#endif /* %s */" "${fileguard}" > + printf "\n" Why not add the "\n" to the end of the previous line? Anyway, Acked-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
