Re: [PATCH] parisc: fix compilation errrors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 8/22/19 1:53 PM, Helge Deller wrote:
On 15.08.19 23:02, Guenter Roeck wrote:
On Thu, Aug 15, 2019 at 04:53:05PM -0400, Qian Cai wrote:
The commit 0cfaee2af3a0 ("include/asm-generic/5level-fixup.h: fix
variable 'p4d' set but not used") converted a few functions from macros
to static inline, which causes parisc to complain,

In file included from ./include/asm-generic/4level-fixup.h:38:0,
                  from ./arch/parisc/include/asm/pgtable.h:5,
                  from ./arch/parisc/include/asm/io.h:6,
                  from ./include/linux/io.h:13,
                  from sound/core/memory.c:9:
./include/asm-generic/5level-fixup.h:14:18: error: unknown type name
'pgd_t'; did you mean 'pid_t'?
  #define p4d_t    pgd_t
                   ^
./include/asm-generic/5level-fixup.h:24:28: note: in expansion of macro
'p4d_t'
  static inline int p4d_none(p4d_t p4d)
                             ^~~~~

It is because "4level-fixup.h" is included before "asm/page.h" where
"pgd_t" is defined.

Fixes: 0cfaee2af3a0 ("include/asm-generic/5level-fixup.h: fix variable 'p4d' set but not used")
Reported-by: Guenter Roeck <linux@xxxxxxxxxxxx>
Signed-off-by: Qian Cai <cai@xxxxxx>

Tested-by: Guenter Roeck <linux@xxxxxxxxxxxx>

Acked-by: Helge Deller <deller@xxxxxx>

Helge


Any chance to push this patch into mainline anytime soon ? It has been applied
to -next, but all parisc builds in mainline are still broken.

Thanks,
Guenter



[Index of Archives]     [Linux SoC]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux