On 2019-07-08, Michael Ellerman <mpe@xxxxxxxxxxxxxx> wrote: > Aleksa Sarai <cyphar@xxxxxxxxxx> writes: > > diff --git a/tools/testing/selftests/openat2/Makefile b/tools/testing/selftests/openat2/Makefile > > new file mode 100644 > > index 000000000000..8235a49928f6 > > --- /dev/null > > +++ b/tools/testing/selftests/openat2/Makefile > > @@ -0,0 +1,12 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > + > > +CFLAGS += -Wall -O2 -g > > +TEST_GEN_PROGS := linkmode_test resolve_test rename_attack_test > > + > > +include ../lib.mk > > + > > +$(OUTPUT)/linkmode_test: linkmode_test.c helpers.o > > +$(OUTPUT)/rename_attack_test: rename_attack_test.c helpers.o > > +$(OUTPUT)/resolve_test: resolve_test.c helpers.o > > You don't need to tell make that foo depends on foo.c. > > Also if you make the dependency be on helpers.c then you won't get an > intermediate helpers.o, and then you don't need to clean it. > > So the above three lines could just be: > > $(TEST_GEN_PROGS): helpers.c I had some trouble getting this to work (hence why I went with the version in the patch), but it looks like this works. I'll include it in the next set. > > +EXTRA_CLEAN = helpers.o $(wildcard /tmp/ksft-openat2-*) > > If you follow my advice above you don't need helpers.o in there. > > Deleting things from /tmp is also a bit fishy on shared machines, ie. it > will error if those files happen to be owned by another user. Good point. I'll drop that hunk in the next set. Thanks! -- Aleksa Sarai Senior Software Engineer (Containers) SUSE Linux GmbH <https://www.cyphar.com/>
Attachment:
signature.asc
Description: PGP signature
