Re: [PATCH v2 1/6] parisc: add support for patching multiple words

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, Jun 04, 2019 at 09:21:34PM +0200, Rolf Eike Beer wrote:
> Sven Schnelle wrote:
> > +	while (len >= 4) {
> > +		*p++ = *insn++;
> > +		addr += sizeof(u32);
> > +		len -= sizeof(u32);
> > +		if (len && !((unsigned long)addr & ~PAGE_MASK)) {
> 
> if (len && offset_in_page(addr) == 0)
> 
> This is a bit more obvious to me. YMMV.

It is. I'll update the patch and send a v3. Thanks!

Sven



[Index of Archives]     [Linux SoC]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux