Hi Rolf, On Fri, 12 Oct 2018 at 17:37, Rolf Eike Beer <eike-kernel@xxxxxxxxx> wrote: > > Firoz Khan wrote: > > > diff --git a/arch/parisc/kernel/syscalls/syscallhdr.sh > > b/arch/parisc/kernel/syscalls/syscallhdr.sh > > new file mode 100644 > > index 0000000..607d4ca > > --- /dev/null > > +++ b/arch/parisc/kernel/syscalls/syscallhdr.sh > > @@ -0,0 +1,35 @@ > > +#!/bin/sh > > +# SPDX-License-Identifier: GPL-2.0 > > + > > +in="$1" > > +out="$2" > > +my_abis=`echo "($3)" | tr ',' '|'` > > Any reason not to use $() instead of backticks? I got this frame work from x86/entry/syscalls; https://github.com/torvalds/linux/blob/master/arch/x86/entry/syscalls/syscallhdr.sh I haven't modified the script but I tune this script to meet my requirements. Sure, I'll look into this. > > > +prefix="$4" > > +offset="$5" > > + > > +fileguard=_UAPI_ASM_PARISC_`basename "$out" | sed \ > > + -e 'y/abcdefghijklmnopqrstuvwxyz/ABCDEFGHIJKLMNOPQRSTUVWXYZ/' \ > > + -e 's/[^A-Z0-9_]/_/g' -e 's/__/_/g'` > > +grep -E "^[0-9A-Fa-fXx]+[[:space:]]+${my_abis}" "$in" | sort -n | ( > > + echo "#ifndef ${fileguard}" > > + echo "#define ${fileguard}" > > + echo "" > > + > > + nxt=0 > > + while read nr abi name entry compat ; do > > + if [ -z "$offset" ]; then > > + echo -e "#define __NR_${prefix}${name}\t$nr" > > This mixed indentation with both tabs and spaces is a bit messy. Is this what you suggested? - echo -e "#define __NR_${prefix}${name}\t$nr" + echo "#define __NR_${prefix}${name} $nr" > > > + else > > + echo -e "#define __NR_${prefix}${name}\t($offset + $nr)" > > + fi > > + nxt=$nr > > + let nxt=nxt+1 > > Why do you use let here when you do $(()) calculations at other places? Yes, will do this. - nxt=$nr - let nxt=nxt+1 + nxt=$((nxt+1)) > > > + done > > + > > + echo "" > > + echo "#ifdef __KERNEL__" > > + echo -e "#define __NR_syscalls\t$nxt" > > + echo "#endif" > > + echo "" > > + echo "#endif /* ${fileguard} */" > > +) > "$out" > > diff --git a/arch/parisc/kernel/syscalls/syscalltbl.sh > > b/arch/parisc/kernel/syscalls/syscalltbl.sh > > new file mode 100644 > > index 0000000..04abde7 > > --- /dev/null > > +++ b/arch/parisc/kernel/syscalls/syscalltbl.sh > > @@ -0,0 +1,46 @@ > > +#!/bin/sh > > +# SPDX-License-Identifier: GPL-2.0 > > + > > +in="$1" > > +out="$2" > > +my_abis=`echo "($3)" | tr ',' '|'` > > +offset="$4" > > + > > +emit() { > > + nxt="$1" > > + if [ -z "$offset" ]; then > > + nr="$2" > > + else > > + nr="$2" > > + nr=$((nr+offset)) > > This could be one line, no? Or just set offset to 0 if it is empty and > avoid that if alltogether. Sure! > > > + fi > > + entry="$3" > > + > > + while [ $nxt -lt $nr ]; do > > + echo "__SYSCALL($nxt, sys_ni_syscall, )" > > + let nxt=nxt+1 > > + done > > + echo "__SYSCALL($nxt, $entry, )" > > +} > > + > > +grep -E "^[0-9A-Fa-fXx]+[[:space:]]+${my_abis}" "$in" | sort -n | ( > > + if [ -z "$offset" ]; then > > + nxt=0 > > + else > > + nxt=$offset > > + fi > > Another argument for offset=0 as default. Sure. > > > + > > + my_abi="$(cut -d'|' -f2 <<< $my_abis)" > > "<<<" is a bash extension and will not work with /bin/sh. Ohh, ok > > > + while read nr abi name entry compat ; do > > + if [ $my_abi = "compat" ]; then > > + if [ -z "$compat" ]; then > > + emit $nxt $nr $entry > > + else > > + emit $nxt $nr $compat > > + fi > > + else > > + emit $nxt $nr $entry > > + fi > > I would go for a local variable being set to $compat or $entry and > calling emit at only one place. And there should be only one if with 2 > expressions, no need for 3 branches. Sure. > > > + let nxt=nxt+1 > > Inconsistent indentation. I'm using emacs editor with default settings. In the actual file, there is no indentation problem which I found but if I get patch using git format-patch, it has inconsistent indentation. No idea. I could find the same problem in other patches also. Let me use the vi editor to save the file and get the patch. Thanks Firoz > > > + done > > +) > "$out" > > Eike
