Hi Arnd, On Thu, 11 Oct 2018 at 12:37, Arnd Bergmann <arnd@xxxxxxxx> wrote: > > On Thu, Oct 11, 2018 at 8:10 AM Firoz Khan <firoz.khan@xxxxxxxxxx> wrote: > > On Wed, 10 Oct 2018 at 01:48, Helge Deller <deller@xxxxxx> wrote: > > > > > > * Firoz Khan <firoz.khan@xxxxxxxxxx>: > > > > System call table generation script must be run to generate > > > > unistd_32/64.h and syscall_table_32/64/c32.h files. This patch > > > > will have changes which will invokes the script. > > > > > > > > This patch will generate unistd_32/64.h and syscall_table_ > > > > 32/64/c32.h files by the syscall table generation script > > > > invoked by arch/parisc/Makefile and the generated files against > > > > the removed files will be identical. > > > > > > > > The generated uapi header file will be included in uapi/asm/ > > > > unistd_32/64.h and generated system call table support file will > > > > be included by arch/sparc/kernel/syscall_table_32/64.S file. > > > > > > > > Signed-off-by: Firoz Khan <firoz.khan@xxxxxxxxxx> > > > > --- > > > > arch/parisc/Makefile | 4 + > > > > arch/parisc/include/asm/Kbuild | 3 + > > > > arch/parisc/include/uapi/asm/Kbuild | 2 + > > > > arch/parisc/include/uapi/asm/unistd.h | 373 +-------------------------- > > > > arch/parisc/kernel/syscall.S | 12 +- > > > > arch/parisc/kernel/syscall_table.S | 459 ---------------------------------- > > > > > > > > > Can we please get rid of those two new files: > > > > Yes, we don't need those files some of the architecture and other > > architecture does have same/similar files. That's why I added below > > files, so every architecture implementation looks same. > > > > I feel it is better to remove these files. > > Arnd, Do u have any comment on this? > > I agree with Helge. This was a big different in a previous version where > you generated the syscall_table.S file from syscalls.tbl, but now that > you generade the syscall_table.h file instead, we no longer need to > keep the .S file synchronized across architectures. > > Having a separate .S file would make it easier to replace that with > a .c file later, but it's also easier to split it out after your series than > as part of it. Sure. Thanks for your comments. Firoz > > Arnd
