Re: convert parisc to the generic dma-noncoherent code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 17.07.2018 15:19, Christoph Hellwig wrote:
> On Sun, Jul 15, 2018 at 12:29:37PM -0400, John David Anglin wrote:
>> On 2018-07-13 4:14 AM, Helge Deller wrote:
>>> On 11.07.2018 17:34, Christoph Hellwig wrote:
>>>> ping?  Any comments?
>>> I applied those 3 patches on top of git head, and booted the
>>> 32-bit kernel on a HP 715/64 (PCX-L) and a HP B160L (PCX-L2).
>>> On both machines I had problems with those drivers which use
>>> DMA (I checked specifically the lasi NIC card, which is the
>>> main onboard NIC card in both machines).
>>> Getting IP via DHCP was unreliable, pings on the same network
>>> to both machines gave lost packets, login via ssh sometimes failed
>>> and so on.
>>>
>>> So, there is definitively some cache-flush missing in this patchset.
>> Possibly, the code should use flush_kernel_vmap_range() as it purges the 
>> TLB entries used
>> for the cache flush.  Some of the routines in pci-dma.c currently use it.
> 
> That might be worth a try and is already discussed in my description.
> 
> Also it might be good to check that the last patch really is the culprit,
> I'm pretty certain it is, but a double check never hurts.

Somehow I now can't reproduce the cache issues any longer. Both, your original
patch and when using flush_kernel_vmap_range(), both work.

So, you can add a 
Tested-by: Helge Deller <deller@xxxxxx>
to your original patch series.

Helge
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SoC]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux