On (10/04/17 11:21), Petr Mladek wrote: [..] > > +#ifdef PPC64_ELF_ABI_v1 > > +unsigned long dereference_module_function_descriptor(struct module *mod, > > + unsigned long addr) > > +{ > > + if (addr < mod->arch.start_opd || addr >= mod->arch.end_opd) > > + return addr; > > + > > + return dereference_function_descriptor(addr); > > +} > > +#endif /* PPC64_ELF_ABI_v1 */ > > I would personally move this up in the source file. It is related to > the definition of func_desc() and other functions that are > also PPC_ELF_ABI-specific. > > Otherwise, it looks good to me. > > Reviewed-by: Petr Mladek <pmladek@xxxxxxxx> OK, will move. -ss -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html