Re: [RFC][PATCH v2 7/7] checkpatch: add pF/pf deprecation warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2017-09-21 at 09:27 +0900, Sergey Senozhatsky wrote:
> On (09/20/17 10:38), Joe Perches wrote:
> > On Thu, 2017-09-21 at 01:29 +0900, Sergey Senozhatsky wrote:
> > > We deprecated '%pF/%pf' printk specifiers, since '%pS/%ps' is now smart
> > > enough to handle function pointer dereference on platforms where such
> > > dereference is required.
> > > 
> > > checkpatch warning example:
> > > 
> > > WARNING: Use '%pS/%ps' instead. This pointer extension was deprecated: '%pF'
> > 
> > If this series is accepted,  I think this message
> > is unclear and would prefer something like:
> 
> sure, can tweak the patch.
> 
> [..]
> >  			if ($bad_extension ne "") {
> >  				my $stat_real = raw_line($linenr, 0);
> > +				my $ext_type = "Invalid";
> > +				my $use = "";
> >  				for (my $count = $linenr + 1; $count <= $lc; $count++) {
> >  					$stat_real = $stat_real . "\n" . raw_line($count, 0);
> >  				}
> > +				if ($bad_extension =~ /p[Ff]/i) {
> 
> 						I think /i is not necessary here

You are right, it's not.

--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SoC]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux