Re: [PATCH] 53c700: fix BUG on untagged commands

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jun 13, 2016 at 10:00:07PM -0700, James Bottomley wrote:
> The untagged command case in the 53c700 driver has been broken since
> host wide tags were enabled because the replaced scsi_find_tag()
> function had a special case for the tag value SCSI_NO_TAG to retrieve
> sdev->current_cmnd.  The replacement function scsi_host_find_tag() has
> no such special case and returns NULL causing untagged commands to
> trigger a BUG() in the driver.  Inspection shows that the 53c700 is the
> only driver using this SCSI_NO_TAG case, so a local fix in the driver
> suffices to fix this problem globally.
> 
> Fixes: 64d513ac31b - "scsi: use host wide tags by default"
> Cc: stable@xxxxxxxxxxxxxxx	# 4.4+
> Reported-by: Helge Deller <deller@xxxxxx>
> Tested-by: Helge Deller <deller@xxxxxx>
> Signed-off-by: James Bottomley <jejb@xxxxxxxxxxxxxxxxxx>

Reviewed-by: Johannes Thumshirn <jthumshirn@xxxxxxx>

-- 
Johannes Thumshirn                                          Storage
jthumshirn@xxxxxxx                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux SoC]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux