On Wed, May 25, 2016 at 10:53 AM, Helge Deller <deller@xxxxxx> wrote: > * Paul Moore <pmoore@xxxxxxxxxx>: >> On Sat, Apr 30, 2016 at 4:51 PM, Helge Deller <deller@xxxxxx> wrote: >> > On 15.04.2016 17:11, Helge Deller wrote: >> >> This patch (v3) adds support for the parisc and parisc64 architectures >> >> to libseccomp. >> > >> > Linux kernel 4.5.2-1 with full seccomp support for parisc/hppa is >> > now publically available in debian: >> > https://buildd.debian.org/status/package.php?p=linux&suite=sid >> > >> > Any chance to get this patch (v3) applied to the libseccomp git tree now ? >> >> Hi Helge, >> >> I apologize for the delay, but I finally got around to merging your >> code and noticed a problem: you're missing the parisc enablement code >> in src/arch-syscall-check.c which has hidden a number of issues with >> the parsic{64} syscall table (run 'make check'). Could you add the >> missing code to arch-syscall-check.c and update the syscall table? > > Indeed. I missed that. > Below is the updated patch (v4) which addresses this issue. > > It survived all "make check" tests on x64_64 and parisc, as well as the > live regression tests on parisc. > > Thanks, > Helge > > xxxxxxxxxxxxxxxxxxxxxxxxxxxxx > > This patch (v4) adds support for the parisc and parisc64 architectures > to libseccomp. > > I didn't split up the patch, because it's pretty trivial. > Those parisc-specific files gets added: > src/arch-parisc-syscalls.c > src/arch-parisc.c > src/arch-parisc.h > src/arch-parisc64.c > > All other changes are trivial because they simply add parisc-specific > case statements in variouse switch statements. > > I did ran a "make check" on x86-64 and parisc and all testcases succeeded. > All live testcases succeed as well when running "./regression -T live". > > The patch applies cleanly to current libseccomp git head. > > Changes between v4 and v3 of this patch: > - Added parisc arch to arch-syscall-check.c and fixup syscall table as > needed > - Fixed copyright notices in parisc files as suggested by Mike Frysinger > > Changes between v3 and v2 of this patch: > - Stripped out patch which reports if a check was skipped because > valgrind isn't installed. > - Added tuxcall pseudo syscall for 19-sim-missing_syscalls testcase > - Added sysmips pseudo syscall for 29-sim-pseudo_syscall testcase > > Changes between v2 and v1 of this patch: > - Enabled seccomp mode 2 regression tests on parisc. Kernel support for > hppa was added in kernel 4.6-rc1 and backported into the kernel v4.5.2 > stable series. > > Thanks, > Helge > > Signed-off-by: Helge Deller <deller@xxxxxx> > > > > diffstat: > include/seccomp.h.in | 6 > src/Makefile.am | 2 > src/arch-parisc-syscalls.c | 499 ++++++++++++++++++++++++++++++++++++++ > src/arch-parisc.c | 22 + > src/arch-parisc.h | 38 ++ > src/arch-parisc64.c | 22 + > src/arch-syscall-check.c | 11 > src/arch-syscall-dump.c | 5 > src/arch.c | 13 > src/gen_pfc.c | 4 > src/python/libseccomp.pxd | 2 > src/python/seccomp.pyx | 8 > tests/26-sim-arch_all_be_basic.c | 6 > tests/26-sim-arch_all_be_basic.py | 2 > tests/regression | 3 > tools/scmp_arch_detect.c | 6 > tools/scmp_bpf_sim.c | 4 > tools/util.c | 4 > 18 files changed, 656 insertions(+), 1 deletion(-) I had to fix-up a few formatting errors found by 'make check-syntax', but it looks reasonable to me, I'm merging it now and it should be part of the v2.4 release. Thanks for your help! -- paul moore www.paul-moore.com -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
