On Wed, 2016-01-13 at 17:39 +0100, Anton Wuerfel wrote:
> Checkpatch outputs some warnings about incorrect comment style,
> which is fixed by this patch.
>
> --- a/drivers/tty/serial/8250/8250_ingenic.c
> +++ b/drivers/tty/serial/8250/8250_ingenic.c
> @@ -152,14 +152,18 @@ static void ingenic_uart_serial_out(struct
> uart_port *p, int offset, int value)
> break;
>
> case UART_IER:
> - /* Enable receive timeout interrupt with the
> - * receive line status interrupt */
> + /*
> + * Enable receive timeout interrupt with the
> + * receive line status interrupt
I'm pretty sure that at least one word could fit previous line.
Can you re-check your patches with sane editor setting for line
breaking (like 76 characters)?
> + */
> value |= (value & 0x4) << 2;
> break;
>
> case UART_MCR:
> - /* If we have enabled modem status IRQs we should
> enable modem
> - * mode. */
> + /*
> + * If we have enabled modem status IRQs we should
> enable modem
> + * mode.
To check.
> + */
>
> @@ -367,8 +367,10 @@ static const struct pnp_device_id
> pnp_dev_table[] = {
> { "PNPCXXX", UNKNOWN_DEV },
> /* More unknown PnP modems */
> { "PNPDXXX", UNKNOWN_DEV },
> - /* Winbond CIR port, should not be probed. We should keep
> track
> - of it to prevent the legacy serial driver from probing it
> */
> + /*
> + * Winbond CIR port, should not be probed. We should keep
> track
> + * of it to prevent the legacy serial driver from probing it
I would suggest to add dot at the end of sentences. Here and in the
rest of the places.
> --- a/drivers/tty/serial/8250/8250_port.c
> +++ b/drivers/tty/serial/8250/8250_port.c
> @@ -250,9 +250,11 @@ static const struct serial8250_config
> uart_config[] = {
> .fcr = UART_FCR_ENABLE_FIFO |
> UART_FCR_R_TRIG_10,
> .flags = UART_CAP_FIFO |
> UART_CAP_AFE,
> },
> -/* tx_loadsz is set to 63-bytes instead of 64-bytes to implement
> -workaround of errata A-008006 which states that tx_loadsz should be
> -configured less than Maximum supported fifo bytes */
> + /*
> + * tx_loadsz is set to 63-bytes instead of 64-bytes to
> implement
> + * workaround of errata A-008006 which states that tx_loadsz
> should be
> + * configured less than Maximum supported fifo bytes
Ditto.
> --- a/drivers/tty/serial/8250/serial_cs.c
> +++ b/drivers/tty/serial/8250/serial_cs.c
> @@ -441,16 +441,20 @@ static int simple_config(struct pcmcia_device
> *link)
> struct serial_info *info = link->priv;
> int i = -ENODEV, try;
>
> - /* First pass: look for a config entry that looks normal.
> - * Two tries: without IO aliases, then with aliases */
> + /*
> + * First pass: look for a config entry that looks normal.
> + * Two tries: without IO aliases, then with aliases
Ditto.
> @@ -480,8 +484,10 @@ static int multi_config_check(struct
> pcmcia_device *p_dev, void *priv_data)
> if (p_dev->resource[1]->end)
> return -EINVAL;
>
> - /* The quad port cards have bad CIS's, so just look for a
> - window larger than 8 ports and assume it will be right */
> + /*
> + * The quad port cards have bad CIS's, so just look for a
> + * window larger than 8 ports and assume it will be right
Ditto.
> - /* Another check for dual-serial cards: look for either
> serial or
> - multifunction cards that ask for appropriate IO port
> ranges */
> + /*
> + * Another check for dual-serial cards: look for either
> serial or
> + * multifunction cards that ask for appropriate IO port
> ranges
Ditto.
--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
