On Fri, 2016-01-08 at 18:43 +0100, Anton Wuerfel wrote:
> Checkpatch complains about incorrect indentation of switch/case
> statements.
> This patch fixes the corresponding warnings. Additionally some
> indentation
> is changed to match the correct format specified in the Linux Kernel
> Coding Style.
>
> Signed-off-by: Anton Würfel <anton.wuerfel@xxxxxx>
> Signed-off-by: Phillip Raffeck <phillip.raffeck@xxxxxx>
> CC: linux-kernel@xxxxxxxxxxxx
> ---
> drivers/tty/serial/8250/8250_pci.c | 12 ++++++------
> drivers/tty/serial/8250/8250_pnp.c | 4 ++--
> drivers/tty/serial/8250/8250_port.c | 6 +++---
> 3 files changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_pci.c
> b/drivers/tty/serial/8250/8250_pci.c
> index 09157fa..b0b47f9 100644
> --- a/drivers/tty/serial/8250/8250_pci.c
> +++ b/drivers/tty/serial/8250/8250_pci.c
> @@ -841,12 +841,12 @@ static int pci_netmos_init(struct pci_dev *dev)
> return 0;
>
> switch (dev->device) { /* FALLTHROUGH on all */
> - case PCI_DEVICE_ID_NETMOS_9904:
> - case PCI_DEVICE_ID_NETMOS_9912:
> - case PCI_DEVICE_ID_NETMOS_9922:
> - case PCI_DEVICE_ID_NETMOS_9900:
> - num_serial = pci_netmos_9900_numports(dev);
> - break;
> + case PCI_DEVICE_ID_NETMOS_9904:
> + case PCI_DEVICE_ID_NETMOS_9912:
> + case PCI_DEVICE_ID_NETMOS_9922:
> + case PCI_DEVICE_ID_NETMOS_9900:
> + num_serial = pci_netmos_9900_numports(dev);
> + break;
>
> default:
You forget to shift above line as well.
> if (num_serial == 0) {
But before doing that I would suggest to refactor the warning message
below in the code: copy it out of 'default:' to below condition and
replace by 'break;' inside the switch-case.
--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
