On Fri, 2016-01-08 at 18:43 +0100, Anton Wuerfel wrote:
> From: Phillip Raffeck <phillip.raffeck@xxxxxx>
>
> This patch replaces printk by the corresponding variant of dev_* in
> order
> to fix checkpatch warnings. If no suitable device pointer is present,
> the
> corresponding pr_* variant is used.
>
> --- a/drivers/tty/serial/8250/8250_hp300.c
> +++ b/drivers/tty/serial/8250/8250_hp300.c
>
> @@ -141,13 +141,13 @@ int __init hp300_setup_serial_console(void)
> if (DIO_ID(pa + DIO_VIRADDRBASE) & 0x80)
> add_preferred_console("ttyS", port.line,
> "9600n8");
> #else
> - printk(KERN_WARNING "Serial console is DCA but
> support is disabled (CONFIG_HPDCA)!\n");
> + pr_warn("Serial console is DCA but support is
> disabled (CONFIG_HPDCA)!\n");
> return 0;
> #endif
> }
>
> if (early_serial_setup(&port) < 0)
> - printk(KERN_WARNING "hp300_setup_serial_console():
> early_serial_setup() failed.\n");
> + pr_warn("hp300_setup_serial_console():
> early_serial_setup() failed.\n");
%s:…, __func__ ?
> return 0;
> }
> #endif /* CONFIG_SERIAL_8250_CONSOLE */
> @@ -179,8 +179,9 @@ static int hpdca_init_one(struct dio_dev *d,
> line = serial8250_register_8250_port(&uart);
>
> if (line < 0) {
> - printk(KERN_NOTICE "8250_hp300: register_serial()
> DCA scode %d"
> - " irq %d failed\n", d->scode, uart.port.irq);
> + dev_notice(&d->dev,
> + "8250_hp300: register_serial() DCA scode
> %d irq %d failed\n",
> + d->scode, uart.port.irq);
> return -ENOMEM;
> }
>
> @@ -260,8 +261,8 @@ static int __init hp300_8250_init(void)
> line = serial8250_register_8250_port(&uart);
>
> if (line < 0) {
> - printk(KERN_NOTICE "8250_hp300:
> register_serial() APCI"
> - " %d irq %d failed\n", i,
> uart.port.irq);
> + pr_notice("8250_hp300: register_serial()
> APCI %d irq %d failed\n",
> + i, uart.port.irq);
Inconsistent with dev_notice() above. Choose one which is most suitable
here.
--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
