On Tue, 2015-12-29 at 21:22 +0100, Helge Deller wrote: > Hi Rasmus, > > On 29.12.2015 21:03, Rasmus Villemoes wrote: > > Line 474 of drivers/parisc/dino.c reads > > > > res->name = dino_dev->hba.lmmio_space.name; > > > > but res is &dino_dev->hba.lmmio_space, so this seems to just assign > > NULL > > again to res->name. Presumably the allocation of <= 128 bytes never > > fails, but I wonder what the purpose was, and if the confusing else > > branch couldn't just be deleted (and then one should just do res > > ->name = > > kmemdup(name, size+1, GFP_KERNEL); and delete the if as well). > > I'd suggest to just delete the else branch. > Do you want to send a patch with signed-off ? Actually, I'd guess the intention was to put back whatever the contents of lmmio_space.name originally was ... it's usually some default static string. James -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
