Re: [RFC PATCHv2] 64bit LWS CAS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Helge,

On Tue, 26 Aug 2014 22:11:43 +0200
Helge Deller <deller@xxxxxx> wrote:

> should we try to do a last round of cleanup of this patch, since
> I would like to include it in the next push to Linus...
> 
> On 07/30/2014 11:17 AM, Guy Martin wrote:
> >>> Regading the GCC counterpart of the implementation, I'm not sure
> >>> about the way to proceed.
> >>>
> >>> Should I try to detect the presence of the new LWS and use it for
> >>> all CAS operations at init time ?
> >>
> >> I leave this up to Dave & Carlos to answer.
> 
> I think it's OK to stay using the existing 32bit implementation for
> 32bit CAS, and just use the new one for 8/16/64 bit CAS.
> And maybe: If the LWS fails, just crash the application.

I seems like the best solution, at least apps will not use a broken
implementation for 8/16bit.

> >> Should we maybe drop the whole ENABLE_LWS_DEBUG thing? Was it ever
> >> used/enabled?
> >
> > Indeed, I have not tested it and I dropped it in this new patch.
> 
> Good.
> In comments at the top still include info about the debug case:
> -> "If debugging is DISabled:..."

Indeed.

> >>> I guess that using the new LWS unconditionally for all CAS
> >>> operations isn't an option since it will break for newer gcc on
> >>> old kernels.
> >>
> >> Up to now we only had the 32bit CAS working correctly, so we
> >> shouldn't care much about the other CAS anyway.
> >> And if we get it backported into all relevant kernels before we
> >> change gcc I would prefer this hard break...
> 
> I'm still thinking this is the right way.
> 
> Your patch had some whitespace errors too.
> Please run it through the scripts/checkpatch tool in the kernel tree.
> 
> If you like I can take care of the suggested changes and send a
> revised patch for you? Just let me know.


Please go ahead ! I just became a father and as you can imagine, I have
very little time to spend on hacking things up :)

Also, I'm not sure that the asm exception tables are working
correctly. I managed to crash my kernel on several occasions while
passing bad values, causing an invalid pointer dereference.


I'll try to work on the gcc patches but it won't be this week, maybe
next week, or I'll have more time in 2 weeks. If someone wants to step
in, feel free to do so too.

Regards,
  Guy

--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SoC]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux