On Fri, Jul 18, 2014 at 10:49 AM, John David Anglin <dave.anglin@xxxxxxxx> wrote: > On 7/17/2014 4:00 PM, Guy Martin wrote: >> >> +/* Kernel helper for compare-and-exchange a 64-bit value from ELF32. */ >> +static inline long >> +__kernel_cmpxchg_dword32 (int64_t oldval, int64_t newval, int64_t *mem) > > I'm thinking we don't need suffix "32". If a 64-bit runtime is ever > developed, > there probably would be a separate file for it as on arm. > > This discussion has got me thinking that the char and short implementations > may be broken (i.e, > the CAS operation may clobber data adjacent to location being operated on). > I'm thinking we need > separate LWS calls for them. Thoughts? Yes, you need masking or short load variants. How did you test the char and short implementations? ;-) Cheers, Carlos. -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
