Re: [PATCH] Make EWOULDBLOCK be equal to EAGAIN on parisc.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 31, 2014 at 11:53 AM, Helge Deller <deller@xxxxxx> wrote:
> On 01/16/2014 05:17 PM, Guy Martin wrote:
>> On Linux, only parisc uses a different value for EWOULDBLOCK which
>> causes a lot of troubles for applications not checking for both values.
>> Since the hpux compat is long dead, make EWOULDBLOCK behave the same as
>> all other architectures.
>>
>> Signed-off-by: Guy Martin  <gmsoft@xxxxxxxxxxxx>
>
> What's our final decision regarding this patch now?
> Shall we target it for inclusion into 3.14 ?
> If yes, I can include it with my next push request...
>
> Please speak up now...!
>
> Helge
>
>> ---
>>  arch/parisc/include/uapi/asm/errno.h | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/parisc/include/uapi/asm/errno.h b/arch/parisc/include/uapi/asm/errno.h
>> index f3a8aa5..c0ae625 100644
>> --- a/arch/parisc/include/uapi/asm/errno.h
>> +++ b/arch/parisc/include/uapi/asm/errno.h
>> @@ -106,7 +106,7 @@
>>
>>  #define    EALREADY    244    /* Operation already in progress */
>>  #define    EINPROGRESS    245    /* Operation now in progress */
>> -#define    EWOULDBLOCK    246    /* Operation would block (Linux returns EAGAIN) */
>> +#define    EWOULDBLOCK    EAGAIN    /* Operation would block (Not HPUX compliant) */
>>  #define    ENOTEMPTY    247    /* Directory not empty */
>>  #define    ENAMETOOLONG    248    /* File name too long */
>>  #define    ELOOP        249    /* Too many symbolic links encountered */

I think we should do it and fix the userspace fallout by rebuilding.

This is just like non-zero locks were in linuxthreads, a pain and
constant source of bugs.

I'll fixup glibc.

Cheers,
Carlos.
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SoC]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux