On Tue, Oct 01, 2013 at 10:53:31PM +0200, Helge Deller wrote: > So, in summary my patch here is not really necessary, but for the sake of > clean code I think it doesn't hurt either and as such it would be nice if > you could apply it. What? function *must* take any value and try to access it and not cause failure. That's the *whole* purpose of that interface. How is having incomplete spurious checks around it "clean code" in any sense of the word? That doesn't make any sense. Nacked-by: Tejun Heo <tj@xxxxxxxxxx> and *please* don't add any checks like that anywhere else in the kernel. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html