Hi Alex, On 07/10/2013 08:17 AM, gnidorah@xxxxxxxxx wrote: > The patch allows binding of user memory to the AGP GART > on systems with HP Quicksilver AGP bus. This resolves 'bind memory failed' > error seen in dmesg: > > [ 29.365973] [TTM] AGP Bind memory failed. > … > [ 29.367030] [drm] Forcing AGP to PCI mode > > The system doesn't more fail to bind the memory, and hence not falling > back to the PCI mode (if other failures aren't detected). > > This is just a simple write down from the following patches: > agp/amd-k7: Allow binding user memory to the AGP GART [1] > agp/hp-agp: Allow binding user memory to the AGP GART [2] > > Both fixes are in upstream. > > [1] https://lkml.org/lkml/2010/10/15/469 > [2] http://marc.info/?l=linux-ia64&m=131412890819311&w=2 Thanks for the patch!!! Could you please attach patches inline (as text) next time? Our patchwork tool (https://patchwork.kernel.org/project/linux-parisc/list/) missed to pick up your patch too. Furthermore, I just noticed that vger.kernel.org stopped forwarding me mails to the mailing list during the last few days. So, I would have missed your patch if I wouldn't have noticed the failing forwarding. Thanks, Helge PS: I attached it here again for patchwork.... diff --git a/drivers/char/agp/parisc-agp.c b/drivers/char/agp/parisc-agp.c index 94821ab..9576fad 100644 --- a/drivers/char/agp/parisc-agp.c +++ b/drivers/char/agp/parisc-agp.c @@ -129,7 +129,8 @@ parisc_agp_insert_memory(struct agp_memory *mem, off_t pg_start, int type) off_t j, io_pg_start; int io_pg_count; - if (type != 0 || mem->type != 0) { + if (type != mem->type || + agp_bridge->driver->agp_type_to_mask_type(agp_bridge, type)) { return -EINVAL; } @@ -175,7 +176,8 @@ parisc_agp_remove_memory(struct agp_memory *mem, off_t pg_start, int type) struct _parisc_agp_info *info = &parisc_agp_info; int i, io_pg_start, io_pg_count; - if (type != 0 || mem->type != 0) { + if (type != mem->type || + agp_bridge->driver->agp_type_to_mask_type(agp_bridge, type)) { return -EINVAL; } -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
