Re: [PATCH] parisc: delete __cpuinit usage from all users

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 13-06-17 06:47 PM, James Bottomley wrote:
> On Mon, 2013-06-17 at 16:34 -0400, Paul Gortmaker wrote:
>> The __cpuinit type of throwaway sections might have made sense
>> some time ago when RAM was more constrained, but now the savings
>> do not offset the cost and complications.  For example, the fix in
>> commit 5e427ec2d0 ("x86: Fix bit corruption at CPU resume time")
>> is a good example of the nasty type of bugs that can be created
>> with improper use of the various __init prefixes.
>>
>> After a discussion on LKML[1] it was decided that cpuinit should go
>> the way of devinit and be phased out.  Once all the users are gone,
>> we can then finally remove the macros themselves from linux/init.h.
> 
> Fine by us ... I'd recommend just rolling this into one patch for all
> the cpuinit tags and sending it via the trivial tree (which goes to
> linux-next) that way we'll know if we do anything to compromise it.

Thanks James,

I'll add an ack'd by for you and keep it with the arch agnostic
chunks.  I do want it to go by the arch maintainers 1st though,
and give them 1st right of refusal on carrying the change; e.g.
for MIPS, Ralf wanted to carry the patch due to the level of
tree activity still pending there.  And for sparc, it touches
some trampoline code, so I want to be sure I don't inflict a
silent boot death on the SPARC folks.  It will get in linux-next
though -- I'll be asking Stephen for that shortly.

P.
--

> 
> James
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SoC]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux