Re: [PATCH] parisc: fix LMMIO mismatch between PAT length and MASK register

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jun 14, 2013 at 12:11 AM, Helge Deller <deller@xxxxxx> wrote:
> From: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>
>
> The LMMIO length reported by PAT and the length given by the LBA MASK
> register are not consistent. This leads e.g. to a non-working ATI FireGL
> card with the radeon DRM driver since the memory can't be mapped.
>
> Fix this by correctly adjusting the resource sizes.
>
> Signed-off-by: Helge Deller <deller@xxxxxx>
>
> diff --git a/drivers/parisc/lba_pci.c b/drivers/parisc/lba_pci.c
> index 1f05913..7dc0e40 100644
> --- a/drivers/parisc/lba_pci.c
> +++ b/drivers/parisc/lba_pci.c
> @@ -994,6 +994,15 @@ lba_pat_resources(struct parisc_device *pa_dev, struct lba_device *lba_dev)
>                 case PAT_LMMIO:
>                         /* used to fix up pre-initialized MEM BARs */
>                         if (!lba_dev->hba.lmmio_space.flags) {
> +                               unsigned long lba_len;
> +                               lba_len = ~READ_REG32(lba_dev->hba.base_addr
> +                                               + LBA_LMMIO_MASK);
> +                               if ((p->end - p->start) != lba_len) {
> +                                       pr_warn("PCI%02x LMMIO mismatch between PAT length (0x%lx) and MASK register (0x%lx), fixing.\n",
> +                                         (int)lba_dev->hba.bus_num.start,
> +                                               p->end - p->start, lba_len);
> +                                       p->end = p->start + lba_len;
> +                               }
>                                 sprintf(lba_dev->hba.lmmio_name,
>                                                 "PCI%02x LMMIO",
>                                                 (int)lba_dev->hba.bus_num.start);
> --

With these two patches, does kernel modesetting (and X11?) work?
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SoC]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux