Re: [PATCH] parisc: Use unshadowed index register for flush instructions in flush_dcache_page_asm and flush_icache_page_asm

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 2013-06-02 at 12:21 -0400, John David Anglin wrote:
> The comment at the start of pacache.S states that the base and index  
> registers used for
> fdc,fic, and pdc instructions should not use shadowed registers.   
> Although this is probably
> unnecessary for tmpalias flushes, there is also no reason not to  
> comply.  The same
> index register (%r23) is used as in other routines.

Please don't do this, it's a misinterpretation of the comment.

What the comment is trying to say is that we use unshadowed registers to
pass information to the tmpalias handler in our tlb insertion
interruption.  It's the do_alias macro in entry.S.  The only actual
unshadowed registers it uses are %r23 and %r26.  Apart from these having
to have specific values, the rest of the routine is free to use any
other registers (either shadowed or unshadowed) as it sees fit.

If the comment is unclear, perhaps it needs fixing?

James


--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Linux SoC]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux