[PATCH] PARISC: Change kunmap macro to static inline function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Change kunmap macro to static inline function to fix build error compiling drivers/base/dma-buf.c.

Without the change, the following error can occur:

  CC      drivers/base/dma-buf.o
/home/dave/debian/linux/linux-3.8.5/drivers/base/dma-buf.c: In function 'dma_buf_kunmap': /home/dave/debian/linux/linux-3.8.5/drivers/base/dma-buf.c:427:46: error: macro "kunmap" passed 3 arguments, but takes just 1 /home/dave/debian/linux/linux-3.8.5/drivers/base/dma-buf.c:427:3: warning: statement with no effect [-Wunused-value]
make[7]: *** [drivers/base/dma-buf.o] Error 1
make[6]: *** [drivers/base] Error 2
make[5]: *** [drivers] Error 2
make[4]: *** [sub-make] Error 2
make[3]: *** [all] Error 2
make[3]: Leaving directory `/home/dave/debian/linux/linux-3.8.5/debian/ build/build_hppa_none_parisc64'

I believe parisc is the only arch to implement kunmap using a macro.

Signed-off-by: John David Anglin <dave.anglin@xxxxxxxx>
Cc: "James E.J. Bottomley" <jejb@xxxxxxxxxxxxxxxx>
Cc: Helge Deller <deller@xxxxxx>
---

diff --git a/arch/parisc/include/asm/cacheflush.h b/arch/parisc/include/asm/cacheflush.h
index 79f694f..f0e2784 100644
--- a/arch/parisc/include/asm/cacheflush.h
+++ b/arch/parisc/include/asm/cacheflush.h
@@ -140,7 +140,10 @@ static inline void *kmap(struct page *page)
 	return page_address(page);
 }
 
-#define kunmap(page)			kunmap_parisc(page_address(page))
+static inline void kunmap(struct page *page)
+{
+	kunmap_parisc(page_address(page));
+}
 
 static inline void *kmap_atomic(struct page *page)
 {


--
John David Anglin	dave.anglin@xxxxxxxx


[Index of Archives]     [Linux SoC]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux