On Wed, 9 May 2012, Matt Turner wrote: > On Wed, May 9, 2012 at 6:19 PM, Mikulas Patocka <mpatocka@xxxxxxxxxx> wrote: > > From: Rolf Eike Beer <eike-kernel@xxxxxxxxx> > > > > This was defined in asm/pdc.h which needs to include asm/page.h for > > __PAGE_OFFSET. This leads to an include loop so that page.h eventually will > > include pdc.h again. While this is no problem because of header guards, it is > > a problem because some symbols may be undefined. Such an error is this: > > > > In file included from /home/buildbot/repos/linux/include/linux/bitops.h:35:0, > > from /home/buildbot/repos/linux/include/asm-generic/getorder.h:7, > > from /home/buildbot/repos/linux/arch/parisc/include/asm/page.h:162, > > from /home/buildbot/repos/linux/arch/parisc/include/asm/pdc.h:346, > > from /home/buildbot/repos/linux/arch/parisc/include/asm/processor.h:16, > > from /home/buildbot/repos/linux/arch/parisc/include/asm/spinlock.h:6, > > from /home/buildbot/repos/linux/arch/parisc/include/asm/atomic.h:20, > > from /home/buildbot/repos/linux/include/linux/atomic.h:4, > > from /home/buildbot/repos/linux/include/linux/sysfs.h:20, > > from /home/buildbot/repos/linux/include/linux/kobject.h:21, > > from /home/buildbot/repos/linux/include/linux/device.h:17, > > from /home/buildbot/repos/linux/include/linux/eisa.h:5, > > from /home/buildbot/repos/linux/arch/parisc/kernel/pci.c:11: > > /home/buildbot/repos/linux/arch/parisc/include/asm/bitops.h: In function "set_bit": > > /home/buildbot/repos/linux/arch/parisc/include/asm/bitops.h:82:2: error: implicit declaration of function "_atomic_spin_lock_irqsave" [-Werror=implicit-function-declaration] > > /home/buildbot/repos/linux/arch/parisc/include/asm/bitops.h:84:2: error: implicit declaration of function "_atomic_spin_unlock_irqrestore" [-Werror=implicit-function-declaration] > > > > Signed-off-by: Rolf Eike Beer <eike-kernel@xxxxxxxxx> > > Email address got eaten? I was copying the patch from mailing list web archive and it mangles addresses. I fixed the others addresses, but forgot about this one. Mikulas > > Signed-off-by: Mikulas Patocka <mpatocka@xxxxxxxxxx> >
