Re: [PATCH 4/6] parisc: drop include of asm/pdc.h from asm/hardware.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Apr 21, 2012 at 11:17 AM, Rolf Eike Beer <eike-kernel@xxxxxxxxx> wrote:
> It seems none of the symbols defined by pdc.h is needed,

Rolf,
I looked through both files and I agree whatever dependency might have
exsisted, doesn't appear to now.

thanks for cleaning this up,
grant

> but it introduces an
> include loop causing compile errors:
>
> In file included from /home/buildbot/repos/linux/arch/parisc/include/asm/spinlock.h:4:0,
>                 from /home/buildbot/repos/linux/arch/parisc/include/asm/atomic.h:20,
>                 from /home/buildbot/repos/linux/include/linux/atomic.h:4,
>                 from /home/buildbot/repos/linux/arch/parisc/include/asm/bitops.h:56,
>                 from /home/buildbot/repos/linux/include/linux/bitops.h:35,
>                 from /home/buildbot/repos/linux/include/asm-generic/getorder.h:7,
>                 from /home/buildbot/repos/linux/arch/parisc/include/asm/page.h:162,
>                 from /home/buildbot/repos/linux/arch/parisc/include/asm/pdc.h:346,
>                 from /home/buildbot/repos/linux/arch/parisc/include/asm/hardware.h:5,
>                 from /home/buildbot/repos/linux/arch/parisc/kernel/hardware.c:30:
> /home/buildbot/repos/linux/arch/parisc/include/asm/processor.h:74:16: error: field ‘cpu_type’ has incomplete type
> /home/buildbot/repos/linux/arch/parisc/include/asm/processor.h:77:20: error: field ‘model’ has incomplete type
> /home/buildbot/repos/linux/arch/parisc/include/asm/processor.h: In function ‘parisc_requires_coherency’:
> /home/buildbot/repos/linux/arch/parisc/include/asm/processor.h:349:36: error: ‘mako’ undeclared (first use in this function)
> /home/buildbot/repos/linux/arch/parisc/include/asm/processor.h:349:36: note: each undeclared identifier is reported only once for each function it appears in
> /home/buildbot/repos/linux/arch/parisc/include/asm/processor.h:350:30: error: ‘mako2’ undeclared (first use in this function)
>
> Signed-off-by: Rolf Eike Beer <eike-kernel@xxxxxxxxx>
> ---
>  arch/parisc/include/asm/hardware.h |    1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/parisc/include/asm/hardware.h b/arch/parisc/include/asm/hardware.h
> index 036e703..d1d864b 100644
> --- a/arch/parisc/include/asm/hardware.h
> +++ b/arch/parisc/include/asm/hardware.h
> @@ -2,7 +2,6 @@
>  #define _PARISC_HARDWARE_H
>
>  #include <linux/mod_devicetable.h>
> -#include <asm/pdc.h>
>
>  #define HWTYPE_ANY_ID          PA_HWTYPE_ANY_ID
>  #define HVERSION_ANY_ID                PA_HVERSION_ANY_ID
> --
> 1.7.9.2
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-parisc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux SoC]     [Linux USB Devel]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux