On Tue, Jan 17, 2012 at 4:26 PM, Greg Kroah-Hartman <greg@xxxxxxxxx> wrote: > On Tue, Jan 17, 2012 at 09:14:05PM +0000, James Bottomley wrote: >> This set of build failures just started appearing on parisc: >> >> In file included from drivers/input/serio/serio_raw.c:12: >> include/linux/kref.h: In function 'kref_get': >> include/linux/kref.h:40: error: 'TAINT_WARN' undeclared (first use in this function) >> include/linux/kref.h:40: error: (Each undeclared identifier is reported only once >> include/linux/kref.h:40: error: for each function it appears in.) >> include/linux/kref.h: In function 'kref_sub': >> include/linux/kref.h:65: error: 'TAINT_WARN' undeclared (first use in this function) >> >> It happens because TAINT_WARN is defined in kernel.h and this particular >> compile doesn't seem to include it (no idea why it's just >> manifesting ... probably some #include file untangling exposed it). Fix >> by adding #include <linux/kernel.h> to linux/kref.h > > Does adding <linux/bug.h> fix it instead? We are using WARN_ON() here. > Hm, but that needs kernel.h as well, ugh, what a mess. I've got some work done already towards cleaning this up; aiming for getting it done and in linux-next for the 3.4 cycle. https://lkml.org/lkml/2012/1/4/455 Paul. --- > >> Signed-off-by: James Bottomley <JBottomley@xxxxxxxxxxxxx> > > Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxx> > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
