On Sun, Dec 04, 2011 at 08:22:34AM -0600, James Bottomley wrote: > On Sun, 2011-12-04 at 12:48 +0200, Michael S. Tsirkin wrote: > > On Thu, Nov 24, 2011 at 10:19:34PM +0200, Michael S. Tsirkin wrote: > > > parisc copied pci_iomap from generic code, probably to avoid > > > pulling the rest of iomap.c in. Since that's in > > > a separate file now, we can reuse the common implementation. > > > > > > Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx> > > > > Sorry to nag, any ACKs/NACKs on the parisc part? > > I intend to send this to Linus if there are no > > objections. Thanks! > > Next time, send the patch to linux-arch or linux-parisc ... it helps to > get people to review it. Although this one looks completely trivial, > unless I'm missing something? I think it's trivial but I don't have the setup to even compile it so depend on someone to ack. > Obviously there was a bit of a brain fart when this was done: the parisc > piece shouldn't be a copy of the generic code: we don't have native i/o > ports and emulation is pretty expensive, so we should prefer > IORESOURCE_MEM over IORESOURCE_IO when both are available ... but even > on x86, memory mapping is faster (although not by the order of magnitude > it is on parisc), so it looks like you could fix this in the generic > code. > > James AFAIK, on PCI a resource is either IO or MEM, but never both. What am I missing? -- MST -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
