On Thu, 17 Jun 2010 07:36:53 -0700 (PDT) David Miller <davem@xxxxxxxxxxxxx> wrote: > From: FUJITA Tomonori <fujita.tomonori@xxxxxxxxxxxxx> > Date: Thu, 17 Jun 2010 21:21:13 +0900 > > > On Wed, 16 Jun 2010 23:24:44 -0700 > > "Michael Chan" <mchan@xxxxxxxxxxxx> wrote: > > > >> David, why is dma_is_consistent() always returning 1 on sparc? The > >> streaming DMA is not consistent. > > > > I think that there are some confusion about dma_is_consistent(). Some > > architectures think that dma_is_consistent() is supposed to return 1 > > if they can allocate coherent memory (note that some architectures > > can't allocate coherent memory). > > Right, and that's why it's defined this way. > > If the desired meaning is different, just me know and I'll fix the > sparc definition. I think that there are some other architectures do the same. We need to make sure that all the architectures define dma_is_consistent() in the same meaning if drivers need it. However, I'm not sure we really need dma_is_consistent(). There is only one user of it (and I think we could remove it). In the bnx2 case, we can simply prefetch on all the archs (or just remove the optimization). -- To unsubscribe from this list: send the line "unsubscribe linux-parisc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
